[coreboot-gerrit] Change in coreboot[master]: libpayload: arm64: Make exception handling closer to arm32

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Fri Oct 12 22:19:22 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29018 )

Change subject: libpayload: arm64: Make exception handling closer to arm32
......................................................................


Patch Set 2:

(9 comments)

https://review.coreboot.org/#/c/29018/2/payloads/libpayload/include/arm64/arch/exception.h
File payloads/libpayload/include/arm64/arch/exception.h:

https://review.coreboot.org/#/c/29018/2/payloads/libpayload/include/arm64/arch/exception.h@39
PS2, Line 39: #define ESR_EC_UNKNOWN		0b000000
Avoid gcc v4.3+ binary constant extension: <0b000000>


https://review.coreboot.org/#/c/29018/2/payloads/libpayload/include/arm64/arch/exception.h@40
PS2, Line 40: #define ESR_EC_SVC_64		0b010101
Avoid gcc v4.3+ binary constant extension: <0b010101>


https://review.coreboot.org/#/c/29018/2/payloads/libpayload/include/arm64/arch/exception.h@41
PS2, Line 41: #define ESR_EC_INSN_ABT_LOWER	0b100000
Avoid gcc v4.3+ binary constant extension: <0b100000>


https://review.coreboot.org/#/c/29018/2/payloads/libpayload/include/arm64/arch/exception.h@42
PS2, Line 42: #define ESR_EC_INSN_ABT_SAME	0b100001
Avoid gcc v4.3+ binary constant extension: <0b100001>


https://review.coreboot.org/#/c/29018/2/payloads/libpayload/include/arm64/arch/exception.h@43
PS2, Line 43: #define ESR_EC_DATA_ABT_LOWER	0b100100
Avoid gcc v4.3+ binary constant extension: <0b100100>


https://review.coreboot.org/#/c/29018/2/payloads/libpayload/include/arm64/arch/exception.h@44
PS2, Line 44: #define ESR_EC_DATA_ABT_SAME	0b100101
Avoid gcc v4.3+ binary constant extension: <0b100101>


https://review.coreboot.org/#/c/29018/2/payloads/libpayload/include/arm64/arch/exception.h@45
PS2, Line 45: #define ESR_EC_SERROR		0b101111
Avoid gcc v4.3+ binary constant extension: <0b101111>


https://review.coreboot.org/#/c/29018/2/payloads/libpayload/include/arm64/arch/exception.h@46
PS2, Line 46: #define ESR_EC_SS_SAME		0b110011
Avoid gcc v4.3+ binary constant extension: <0b110011>


https://review.coreboot.org/#/c/29018/2/payloads/libpayload/include/arm64/arch/exception.h@47
PS2, Line 47: #define ESR_EC_BKPT_64		0b111100
Avoid gcc v4.3+ binary constant extension: <0b111100>



-- 
To view, visit https://review.coreboot.org/29018
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia16a1124be1824392a309ae1f4cb031547d184c1
Gerrit-Change-Number: 29018
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 12 Oct 2018 20:19:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181012/7d3fae78/attachment.html>


More information about the coreboot-gerrit mailing list