[coreboot-gerrit] Change in coreboot[master]: security/vboot: Drop `depends on HAVE_HARD_RESET`

Nico Huber (Code Review) gerrit at coreboot.org
Fri Oct 12 20:45:33 CEST 2018


Nico Huber has uploaded this change for review. ( https://review.coreboot.org/29077


Change subject: security/vboot: Drop `depends on HAVE_HARD_RESET`
......................................................................

security/vboot: Drop `depends on HAVE_HARD_RESET`

While this is true in theory, Kconfig gets completely messed up by it:
The `config VBOOT` is redefined all over the place in different Kconfig
files. Thus, having a `depends on` here, only hides this single defini-
tion and the other (incomplete) definitions take over and break the
build.

Change-Id: Ib0e0bcf7d5a662a526ce20f0a6d9cfeb8fafe7fe
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M src/security/vboot/Kconfig
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/29077/1

diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig
index e13101b..0509520 100644
--- a/src/security/vboot/Kconfig
+++ b/src/security/vboot/Kconfig
@@ -18,7 +18,6 @@
 	bool "Verify firmware with vboot."
 	default n
 	select VBOOT_MOCK_SECDATA if !TPM1 && !TPM2
-	depends on HAVE_HARD_RESET
 	help
 	  Enabling VBOOT will use vboot to verify the components of the firmware
 	  (stages, payload, etc).

-- 
To view, visit https://review.coreboot.org/29077
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0e0bcf7d5a662a526ce20f0a6d9cfeb8fafe7fe
Gerrit-Change-Number: 29077
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181012/bfc21e35/attachment.html>


More information about the coreboot-gerrit mailing list