[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Cleanup procedure pci_ehci_dbg_dev()

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29071 )

Change subject: soc/amd/stoneyridge: Cleanup procedure pci_ehci_dbg_dev()
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> I don't believe your patch will work, and it looks to me like you couldn't possibly have built your change.  I was already working on a stack when you pushed this.  See my version at https://review.coreboot.org/#/c/coreboot/+/29074/

I build it, and so has Jenkins... but I believe I know what's wrong... I did not enabled USB debug, so this code was not compiled. Good catch, I needed to include pci_devs.h


-- 
To view, visit https://review.coreboot.org/29071
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95eb2b7be53efe6a7cedf9a2a515d608f2643cf7
Gerrit-Change-Number: 29071
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 12 Oct 2018 18:24:33 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181012/9411667d/attachment.html>