[coreboot-gerrit] Change in coreboot[master]: cpu/amd: Use common AMD's MSR
Martin Roth (Code Review)
gerrit at coreboot.org
Fri Oct 12 18:20:49 CEST 2018
Martin Roth has posted comments on this change. ( https://review.coreboot.org/29065 )
Change subject: cpu/amd: Use common AMD's MSR
......................................................................
Patch Set 5:
> now "src/include/cpu/amd/amdfam1*.h" are empty. should we keep them?
Nope - delete the heck out of those! Thanks.
> one more question:
> page #633 - "AMD64 Architecture Programmer’s Manual - Volume 2"
> we have common Amd64_MSR for exmple this one: "MCG_CAP"
> we can find it in x86/msr.h , but with a "IA32_..."
> should we use the one defined in x86, or define new one for AMD as
> for example "#define AMD64_MCG_CAP 0x179" ?
MSRs that are shared by intel should go into the x86 version, in my opinion.
--
To view, visit https://review.coreboot.org/29065
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0236e0960cd1e79558ea50c814e1de2830aa0550
Gerrit-Change-Number: 29065
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Comment-Date: Fri, 12 Oct 2018 16:20:49 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181012/0fe26373/attachment.html>
More information about the coreboot-gerrit
mailing list