[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/*/acpi: Store the requested state wake state for bluetooth ...

Peter Lemenkov (Code Review) gerrit at coreboot.org
Fri Oct 12 10:14:35 CEST 2018


Hello Patrick Rudolph,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/29064

to review the following change.


Change subject: mb/lenovo/*/acpi: Store the requested state wake state for bluetooth and WWAN.
......................................................................

mb/lenovo/*/acpi: Store the requested state wake state for bluetooth and WWAN.

L520 and T420 should also use it - platforms are very similar to t420s
and t530. Z61t is based on T60/X60, X131e is based on X230 so commit
with Change-Id I13c08b8c6b1bf0f3deb25a464b26880d8469c005 should be
applied as well.

All four platforms are using ec/lenovo/h8 embedded controller.

Change-Id: Ib177f024871e82979dd430da86f1551aef14d446
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
Signed-off-by: Peter Lemenkov <lemenkov at gmail.com>
---
M src/mainboard/lenovo/l520/acpi/platform.asl
M src/mainboard/lenovo/t420/acpi/platform.asl
M src/mainboard/lenovo/x131e/acpi/platform.asl
M src/mainboard/lenovo/z61t/acpi/platform.asl
4 files changed, 14 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/29064/1

diff --git a/src/mainboard/lenovo/l520/acpi/platform.asl b/src/mainboard/lenovo/l520/acpi/platform.asl
index c7aea62..2d016fa 100644
--- a/src/mainboard/lenovo/l520/acpi/platform.asl
+++ b/src/mainboard/lenovo/l520/acpi/platform.asl
@@ -19,6 +19,11 @@
 	/* ME may not be up yet.  */
 	Store (0, \_TZ.MEB1)
 	Store (0, \_TZ.MEB2)
+
+	/* Wake the HKEY to init BT/WWAN */
+	\_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0)
+
+	/* Not implemented.  */
 	Return(Package(){0,0})
 }
 
diff --git a/src/mainboard/lenovo/t420/acpi/platform.asl b/src/mainboard/lenovo/t420/acpi/platform.asl
index 6f26c5a..e4c8a24 100644
--- a/src/mainboard/lenovo/t420/acpi/platform.asl
+++ b/src/mainboard/lenovo/t420/acpi/platform.asl
@@ -32,6 +32,9 @@
 	Store (0, \_TZ.MEB1)
 	Store (0, \_TZ.MEB2)
 
+	/* Wake the HKEY to init BT/WWAN */
+	\_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0)
+
 	/* Not implemented. */
 	Return(Package(){0,0})
 }
diff --git a/src/mainboard/lenovo/x131e/acpi/platform.asl b/src/mainboard/lenovo/x131e/acpi/platform.asl
index 9cd327a..bf686f4 100644
--- a/src/mainboard/lenovo/x131e/acpi/platform.asl
+++ b/src/mainboard/lenovo/x131e/acpi/platform.asl
@@ -32,6 +32,9 @@
 	Store (0, \_TZ.MEB1)
 	Store (0, \_TZ.MEB2)
 
+	/* Wake the HKEY to init BT/WWAN */
+	\_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0)
+
 	/* Not implemented.  */
 	Return(Package(){0,0})
 }
diff --git a/src/mainboard/lenovo/z61t/acpi/platform.asl b/src/mainboard/lenovo/z61t/acpi/platform.asl
index 006b6f0..f9e991b 100644
--- a/src/mainboard/lenovo/z61t/acpi/platform.asl
+++ b/src/mainboard/lenovo/z61t/acpi/platform.asl
@@ -29,6 +29,9 @@
 
 Method(_WAK,1)
 {
+	/* Wake the HKEY to init BT/WWAN */
+	\_SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0)
+
 	// CPU specific part
 
 	// Notify PCI Express slots in case a card

-- 
To view, visit https://review.coreboot.org/29064
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib177f024871e82979dd430da86f1551aef14d446
Gerrit-Change-Number: 29064
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Lemenkov <lemenkov at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181012/c9ad2799/attachment.html>


More information about the coreboot-gerrit mailing list