[coreboot-gerrit] Change in coreboot[master]: nb/via/vx900: Use CF9 reset

Nico Huber (Code Review) gerrit at coreboot.org
Fri Oct 12 00:06:35 CEST 2018


Nico Huber has uploaded this change for review. ( https://review.coreboot.org/29055


Change subject: nb/via/vx900: Use CF9 reset
......................................................................

nb/via/vx900: Use CF9 reset

Change-Id: I2b68a23cdf244884104d4ed54e19d3ab347c3a3e
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M src/northbridge/via/vx900/Kconfig
M src/northbridge/via/vx900/northbridge.c
2 files changed, 1 insertion(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/29055/1

diff --git a/src/northbridge/via/vx900/Kconfig b/src/northbridge/via/vx900/Kconfig
index b666767..8d95942 100644
--- a/src/northbridge/via/vx900/Kconfig
+++ b/src/northbridge/via/vx900/Kconfig
@@ -20,7 +20,7 @@
 	select DRIVERS_GENERIC_IOAPIC
 	select HAVE_DEBUG_RAM_SETUP
 	select HAVE_DEBUG_SMBUS
-	select HAVE_HARD_RESET
+	select HAVE_CF9_RESET
 	select NO_RELOCATABLE_RAMSTAGE
 
 if NORTHBRIDGE_VIA_VX900
diff --git a/src/northbridge/via/vx900/northbridge.c b/src/northbridge/via/vx900/northbridge.c
index 66b2def..5a2ddfb 100644
--- a/src/northbridge/via/vx900/northbridge.c
+++ b/src/northbridge/via/vx900/northbridge.c
@@ -24,7 +24,6 @@
 #include <cpu/cpu.h>
 #include <cbmem.h>
 #include <lib.h>
-#include <reset.h>
 #include <string.h>
 
 #define RAM_4GB		(((u64)1) << 32)
@@ -43,11 +42,6 @@
  * remapping mechanism will overflow, the effects of which are unknown.
  */
 
-void do_hard_reset(void)
-{
-	outb((1 << 2) | (1 << 1), 0xcf9);
-}
-
 uint64_t get_uma_memory_base(void)
 {
 	printk(BIOS_DEBUG, "UMA base 0x%.8llx (%lluMB)\n", uma_memory_base,

-- 
To view, visit https://review.coreboot.org/29055
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b68a23cdf244884104d4ed54e19d3ab347c3a3e
Gerrit-Change-Number: 29055
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181011/b7412316/attachment.html>


More information about the coreboot-gerrit mailing list