[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Set PSPP setting to BalanceLow

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/29028 )

Change subject: mainboard/google/kahlee: Set PSPP setting to BalanceLow
......................................................................

mainboard/google/kahlee: Set PSPP setting to BalanceLow

With correct stapm values audio issue is not observed with
PsPPBalanceLow (Gen1 speed).

BUG=b:117569918
TEST=audio playback multiple times

Change-Id: Iaeae52b262b12622a6753432e3fc40bf5f0fd8e0
Signed-off-by: Akshu Agrawal <akshu.agrawal at amd.com>
Reviewed-on: https://review.coreboot.org/29028
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Martin Roth <martinroth at google.com>
Reviewed-by: Marc Jones <marc at marcjonesconsulting.com>
Reviewed-by: Raul Rangel <rrangel at chromium.org>
---
M src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Marc Jones: Looks good to me, approved
  Martin Roth: Looks good to me, approved
  Raul Rangel: Looks good to me, approved



diff --git a/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c b/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c
index f5cab08..e9cf5c8 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c
@@ -149,7 +149,7 @@
 VOID __weak OemCustomizeInitEarly(IN OUT AMD_EARLY_PARAMS *InitEarly)
 {
 	InitEarly->GnbConfig.PcieComplexList = (void *)&PcieComplex;
-	InitEarly->GnbConfig.PsppPolicy = PsppBalanceHigh;
+	InitEarly->GnbConfig.PsppPolicy = PsppBalanceLow;
 	InitEarly->PlatformConfig.GnbAzI2sBusSelect = GnbAcpI2sBus;
 	InitEarly->PlatformConfig.GnbAzI2sBusPinConfig = GnbAcp2Tx4RxBluetooth;
 	if ((IS_ENABLED(CONFIG_BOARD_GOOGLE_LIARA)) && (board_id() <= 4))

-- 
To view, visit https://review.coreboot.org/29028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaeae52b262b12622a6753432e3fc40bf5f0fd8e0
Gerrit-Change-Number: 29028
Gerrit-PatchSet: 2
Gerrit-Owner: Akshu Agrawal <akshu.agrawal at amd.com>
Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal at amd.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181011/d2cfa0e3/attachment.html>