[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29032 )

Change subject: mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On
......................................................................


Patch Set 3:

I don't see a reason to run this code in SMM.
According to the datasheet it could be set at any time and it survives even reboots, as long as a battery is pluged in.


-- 
To view, visit https://review.coreboot.org/29032
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9070b659b0c9ad5dde4200ec2845c6fa2b78b25
Gerrit-Change-Number: 29032
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Lemenkov <lemenkov at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:43:41 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181011/28a0bce1/attachment.html>