[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Indicate STAPM units in their name

Richard Spiegel (Code Review) gerrit at coreboot.org
Thu Oct 11 17:20:36 CEST 2018


Richard Spiegel has uploaded a new patch set (#2). ( https://review.coreboot.org/29035 )

Change subject: amd/stoneyridge: Indicate STAPM units in their name
......................................................................

amd/stoneyridge: Indicate STAPM units in their name

STAPM devicetree registers do not indicate the unit, which causes confusion.
More importantly, the time was assumed to be in seconds when it's actually
milliseconds. This caused early STAPM configurations to fail.

BUG=b:117590953
TEST=Build grunt

Change-Id: I2a7e3d43601992d1f7b02456913c763d940fe9ee
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/mainboard/google/kahlee/variants/careena/devicetree.cb
M src/mainboard/google/kahlee/variants/grunt/devicetree.cb
M src/soc/amd/stoneyridge/chip.h
M src/soc/amd/stoneyridge/romstage.c
4 files changed, 11 insertions(+), 10 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/29035/2
-- 
To view, visit https://review.coreboot.org/29035
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2a7e3d43601992d1f7b02456913c763d940fe9ee
Gerrit-Change-Number: 29035
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181011/ce805312/attachment.html>


More information about the coreboot-gerrit mailing list