[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add FSP CAR Init support for CFL

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28581 )

Change subject: soc/intel/cannonlake: Add FSP CAR Init support for CFL
......................................................................


Patch Set 11:

(1 comment)

https://review.coreboot.org/#/c/28581/11/src/soc/intel/cannonlake/bootblock/cache_as_ram_fsp.S
File src/soc/intel/cannonlake/bootblock/cache_as_ram_fsp.S:

https://review.coreboot.org/#/c/28581/11/src/soc/intel/cannonlake/bootblock/cache_as_ram_fsp.S@98
PS11, Line 98: 	.long	CONFIG_ROM_SIZE				/* Total Firmware Length */
line over 80 characters



-- 
To view, visit https://review.coreboot.org/28581
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic17bc827e57df6ba0b891f906c7adac1bb5d4d73
Gerrit-Change-Number: 28581
Gerrit-PatchSet: 11
Gerrit-Owner: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Kin Wai Ng <kin.wai.ng at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Teo Boon Tiong <boon.tiong.teo at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 05:49:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181011/49259106/attachment.html>