[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Convert hex definitions to lower case

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Thu Oct 11 01:14:41 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29009 )

Change subject: amd/stoneyridge: Convert hex definitions to lower case
......................................................................


Patch Set 1:

(5 comments)

https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/include/soc/southbridge.h
File src/soc/amd/stoneyridge/include/soc/southbridge.h:

https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/include/soc/southbridge.h@381
PS1, Line 381: #define   CG1PLL_SS_STEP_SIZE_DSFRAC_MASK	(0xffff << CG1PLL_SS_STEP_SIZE_DSFRAC_SHIFT)
line over 80 characters


https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/include/soc/southbridge.h@383
PS1, Line 383: #define   CG1PLL_SS_AMOUNT_DSFRAC_MASK		(0xffff << CG1PLL_SS_AMOUNT_DSFRAC_SHIFT)
line over 80 characters


https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/include/soc/southbridge.h@386
PS1, Line 386: #define   CG1PLL_SS_AMOUNT_NFRAC_SLIP_MASK	(0xf << CG1PLL_SS_AMOUNT_NFRAC_SLIP_SHIFT)
line over 80 characters


https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/southbridge.c
File src/soc/amd/stoneyridge/southbridge.c:

https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/southbridge.c@598
PS1, Line 598: 	cfg4 |= (0xd000 << CG1PLL_SS_AMOUNT_DSFRAC_SHIFT) & CG1PLL_SS_AMOUNT_DSFRAC_MASK;
line over 80 characters


https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/southbridge.c@600
PS1, Line 600: 	cfg4 |= (0x02d5 << CG1PLL_SS_STEP_SIZE_DSFRAC_SHIFT) & CG1PLL_SS_STEP_SIZE_DSFRAC_MASK;
line over 80 characters



-- 
To view, visit https://review.coreboot.org/29009
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4531e6dad0362be73499647d9fc93c168b6f163e
Gerrit-Change-Number: 29009
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 10 Oct 2018 23:14:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181010/ac5df8b2/attachment.html>


More information about the coreboot-gerrit mailing list