[coreboot-gerrit] Change in coreboot[master]: Enable Serial Debug for UEFI payload Debug build
Wonkyu Kim (Code Review)
gerrit at coreboot.org
Wed Oct 10 20:28:33 CEST 2018
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/29004 )
Change subject: Enable Serial Debug for UEFI payload Debug build
......................................................................
Patch Set 3:
(9 comments)
This change is required for enable UART Debug log for UEFI debug build
https://review.coreboot.org/#/c/29004/1/payloads/external/tianocore/patches/05_CorebootPayloadPkg-don-t-use-serial-output-for-Relea.patch
File payloads/external/tianocore/patches/05_CorebootPayloadPkg-don-t-use-serial-output-for-Relea.patch:
https://review.coreboot.org/#/c/29004/1/payloads/external/tianocore/patches/05_CorebootPayloadPkg-don-t-use-serial-output-for-Relea.patch@20
PS1, Line 20: +!if $(TARGET) == DEBUG
> trailing whitespace
Ack
https://review.coreboot.org/#/c/29004/1/payloads/external/tianocore/patches/05_CorebootPayloadPkg-don-t-use-serial-output-for-Relea.patch@21
PS1, Line 21: gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
> trailing whitespace
Done
https://review.coreboot.org/#/c/29004/1/payloads/external/tianocore/patches/05_CorebootPayloadPkg-don-t-use-serial-output-for-Relea.patch@22
PS1, Line 22: +!else
> trailing whitespace
Done
https://review.coreboot.org/#/c/29004/1/payloads/external/tianocore/patches/05_CorebootPayloadPkg-don-t-use-serial-output-for-Relea.patch@24
PS1, Line 24: +!endif
> trailing whitespace
Done
https://review.coreboot.org/#/c/29004/1/payloads/external/tianocore/patches/05_CorebootPayloadPkg-don-t-use-serial-output-for-Relea.patch@36
PS1, Line 36: +!if $(TARGET) == DEBUG
> trailing whitespace
Done
https://review.coreboot.org/#/c/29004/1/payloads/external/tianocore/patches/05_CorebootPayloadPkg-don-t-use-serial-output-for-Relea.patch@37
PS1, Line 37: gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
> trailing whitespace
Done
https://review.coreboot.org/#/c/29004/1/payloads/external/tianocore/patches/05_CorebootPayloadPkg-don-t-use-serial-output-for-Relea.patch@38
PS1, Line 38: +!else
> trailing whitespace
Done
https://review.coreboot.org/#/c/29004/1/payloads/external/tianocore/patches/05_CorebootPayloadPkg-don-t-use-serial-output-for-Relea.patch@40
PS1, Line 40: +!endif
> trailing whitespace
Done
https://review.coreboot.org/#/c/29004/2/payloads/external/tianocore/patches/05_CorebootPayloadPkg-don-t-use-serial-output-for-Relea.patch
File payloads/external/tianocore/patches/05_CorebootPayloadPkg-don-t-use-serial-output-for-Relea.patch:
https://review.coreboot.org/#/c/29004/2/payloads/external/tianocore/patches/05_CorebootPayloadPkg-don-t-use-serial-output-for-Relea.patch@38
PS2, Line 38: +!else
> trailing whitespace
Ack
--
To view, visit https://review.coreboot.org/29004
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29953250ca278d5b1977be3763359df5110f67c7
Gerrit-Change-Number: 29004
Gerrit-PatchSet: 3
Gerrit-Owner: Wonkyu Kim <wonkyu.kim at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 10 Oct 2018 18:28:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181010/538eb67d/attachment.html>
More information about the coreboot-gerrit
mailing list