[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy: Allow variants to provide event info at runtime

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Wed Oct 10 09:00:33 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28983 )

Change subject: mb/google/poppy: Allow variants to provide event info at runtime
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28983/1/src/mainboard/google/poppy/ec.c
File src/mainboard/google/poppy/ec.c:

https://review.coreboot.org/#/c/28983/1/src/mainboard/google/poppy/ec.c@37
PS1, Line 37: 	google_chromeec_events_init(variant_get_event_info(), acpi_is_wakeup_s3());
line over 80 characters



-- 
To view, visit https://review.coreboot.org/28983
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If89e904c92372530a0f555952f87702f068e0b03
Gerrit-Change-Number: 28983
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 10 Oct 2018 07:00:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181010/d7e36399/attachment.html>


More information about the coreboot-gerrit mailing list