[coreboot-gerrit] Change in coreboot[master]: soc/cavium: dynamic UART initialization for cavium cn8100

Patrick Rudolph (Code Review) gerrit at coreboot.org
Tue Oct 9 16:14:27 CEST 2018


Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28975 )

Change subject: soc/cavium: dynamic UART initialization for cavium cn8100
......................................................................


Patch Set 3:

(3 comments)

https://review.coreboot.org/#/c/28975/3//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/28975/3//COMMIT_MSG@9
PS3, Line 9: Now only those UARTs that are enabled in devicetree.cbare initialized.
missing space


https://review.coreboot.org/#/c/28975/3//COMMIT_MSG@11
PS3, Line 11: Tested on Opencellular Elgon
missing .


https://review.coreboot.org/#/c/28975/3/src/soc/cavium/cn81xx/soc.c
File src/soc/cavium/cn81xx/soc.c:

https://review.coreboot.org/#/c/28975/3/src/soc/cavium/cn81xx/soc.c@398
PS3, Line 398: 		/*using device enable state from devicetree.cb*/
missing space 2x



-- 
To view, visit https://review.coreboot.org/28975
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I145c224148f0cc078bb1c76f588f603e73121a62
Gerrit-Change-Number: 28975
Gerrit-PatchSet: 3
Gerrit-Owner: Jens Drenhaus <jens.drenhaus at 9elements.com>
Gerrit-Reviewer: Jens Drenhaus <jens.drenhaus at 9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 09 Oct 2018 14:14:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181009/26de18c2/attachment.html>


More information about the coreboot-gerrit mailing list