[coreboot-gerrit] Change in coreboot[master]: riscv: add physical memory protection (PMP) support

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28569 )

Change subject: riscv: add physical memory protection (PMP) support
......................................................................


Patch Set 8:

(9 comments)

https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c
File src/arch/riscv/pmp.c:

https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@82
PS8, Line 82: 		new = (old & ~((uintptr_t)0xff << shift)) | ((cfg & 0xff) << shift);
line over 80 characters


https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@87
PS8, Line 87: 		new = (old & ~((uintptr_t)0xff << shift)) | ((cfg & 0xff) << shift);
line over 80 characters


https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@92
PS8, Line 92: 		new = (old & ~((uintptr_t)0xff << shift)) | ((cfg & 0xff) << shift);
line over 80 characters


https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@97
PS8, Line 97: 		new = (old & ~((uintptr_t)0xff << shift)) | ((cfg & 0xff) << shift);
line over 80 characters


https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@106
PS8, Line 106: 		new = (old & ~((uintptr_t)0xff << shift)) | ((cfg & 0xff) << shift);
line over 80 characters


https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@111
PS8, Line 111: 		new = (old & ~((uintptr_t)0xff << shift)) | ((cfg & 0xff) << shift);
line over 80 characters


https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@117
PS8, Line 117: 		die("write_pmpcfg failure!");
Prefer using '"%s...", __func__' to using 'write_pmpcfg', this function's name, in a string


https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@123
PS8, Line 123: 	switch(idx) {
space required before the open parenthesis '('


https://review.coreboot.org/#/c/28569/8/src/arch/riscv/pmp.c@214
PS8, Line 214: 		die("write_pmpaddr failure");
Prefer using '"%s...", __func__' to using 'write_pmpaddr', this function's name, in a string



-- 
To view, visit https://review.coreboot.org/28569
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e9e0c94e6518f63ade7680a3ce68bacfae219d4
Gerrit-Change-Number: 28569
Gerrit-PatchSet: 8
Gerrit-Owner: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Hug <philipp at hug.cx>
Gerrit-Reviewer: Shawn Chang <citypw at gmail.com>
Gerrit-Reviewer: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 09 Oct 2018 04:15:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181009/320d720b/attachment.html>