[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/gpio: check for NULL using if statement

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28940 )

Change subject: soc/intel/common/block/gpio: check for NULL using if statement
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/28940/3/src/soc/intel/common/block/gpio/gpio.c
File src/soc/intel/common/block/gpio/gpio.c:

https://review.coreboot.org/#/c/28940/3/src/soc/intel/common/block/gpio/gpio.c@77
PS3, Line 77: 		die("gpio_group_index: Failed to get comm->groups.");
Prefer using '"%s...", __func__' to using 'gpio_group_index', this function's name, in a string



-- 
To view, visit https://review.coreboot.org/28940
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85a6bc700b52d04c61ca8f2baac62000f40cf2cb
Gerrit-Change-Number: 28940
Gerrit-PatchSet: 3
Gerrit-Owner: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-Comment-Date: Mon, 08 Oct 2018 18:59:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181008/8d50ad54/attachment.html>