[coreboot-gerrit] Change in coreboot[master]: nb/i945: Check if IGD is enabled before R/W to dev(0, 2)

[Elyes HAOUAS (Code Review)]

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/28935 )

Change subject: nb/i945: Check if IGD is enabled before R/W to dev(0, 2)
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.c
File src/northbridge/intel/i945/raminit.c:

https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.c@2764
PS1, Line 2764: pci_read_config8(PCI_DEV(0, 0x0, 0), DEVEN) &
              : 			(DEVEN_D2F0 | DEVEN_D2F1)
> Sorry i945_setup_pci_express_x16() is the wrong function for the […]
I'm using i945_setup_pci_express_x16() for desktop version.
ATI pcie card needs this function, but seems that nvidia
don't (see  https://review.coreboot.org/#/c/coreboot/+/27985/ comment in "Patch Set 3" ):

"Arthur Heymans - Aug 10 6:27 PM

Patch Set 3:

So from tests it looks like the datasheet is right when it says PEG and the IGD are mutually exclusive. The best thing to do is to make sure i945_setup_pci_express_x16() works fine for 945GC (iirc it messed up nvidia cards)"



-- 
To view, visit https://review.coreboot.org/28935
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51ab94393710ce0222b353ab0cef28621fafaacf
Gerrit-Change-Number: 28935
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus at gmail.com>
Gerrit-Comment-Date: Mon, 08 Oct 2018 15:36:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181008/36d16b4f/attachment.html>