[coreboot-gerrit] Change in coreboot[master]: nb/i945: Check if IGD is enabled before R/W to dev(0, 2)

[Elyes HAOUAS (Code Review)]

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/28935 )

Change subject: nb/i945: Check if IGD is enabled before R/W to dev(0, 2)
......................................................................


Patch Set 1:

(2 comments)

this is not a real issue ... as it will write to nothing when external GPU is used.

https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.c
File src/northbridge/intel/i945/raminit.c:

https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.c@a2306
PS1, Line 2306: 
              : 
              : 
              : 
> But it shows us what to do if.
if "integrated_graphics" is disabled ?


https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.c@2764
PS1, Line 2764: pci_read_config8(PCI_DEV(0, 0x0, 0), DEVEN) &
              : 			(DEVEN_D2F0 | DEVEN_D2F1)
> Always true?
what I'm trying to explain is :
when the chip is not i945GM but a i945G + an external GPU, IGD is disabled. so write to it do not make sense



-- 
To view, visit https://review.coreboot.org/28935
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51ab94393710ce0222b353ab0cef28621fafaacf
Gerrit-Change-Number: 28935
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus at gmail.com>
Gerrit-Comment-Date: Mon, 08 Oct 2018 10:11:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181008/5016566b/attachment.html>