[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/nocturne: correct wifi wake register

Patrick Georgi (Code Review) gerrit at coreboot.org
Mon Oct 8 11:45:51 CEST 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/28938 )

Change subject: mb/google/poppy/variant/nocturne: correct wifi wake register
......................................................................

mb/google/poppy/variant/nocturne: correct wifi wake register

Wifi wake register is incorrectly set in devicetree.
Set wifi wake to its correct wake source, GPE0_DW2_01.

BUG=b:117330593
TEST='emerge-nocturne coreboot chromeos-bootimage', flash nocture,
connect wifi to a hotspot, suspend device, echo freeze >
/sys/power/state, and then shutdown the hotspot and verify device
wakes.

Change-Id: Iafa865ca79d33541d7f47b69d2fb209e7f9c98af
Signed-off-by: Nick Vaccaro <nvaccaro at google.com>
Reviewed-on: https://review.coreboot.org/28938
Reviewed-by: Furquan Shaikh <furquan at google.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/mainboard/google/poppy/variants/nocturne/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved



diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
index ddb2e34..919a073 100644
--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
@@ -393,7 +393,7 @@
 		end # I2C #4 - Audio
 		device pci 1c.0 on
 			chip drivers/intel/wifi
-				register "wake" = "GPE0_PCI_EXP"
+				register "wake" = "GPE0_DW2_01"
 				device pci 00.0 on end
 			end
 		end # PCI Express Port 1

-- 
To view, visit https://review.coreboot.org/28938
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafa865ca79d33541d7f47b69d2fb209e7f9c98af
Gerrit-Change-Number: 28938
Gerrit-PatchSet: 2
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181008/5c935129/attachment.html>


More information about the coreboot-gerrit mailing list