[coreboot-gerrit] Change in coreboot[master]: Documentation: Improve elgon documentation

Philipp Deppenwiese (Code Review) gerrit at coreboot.org
Mon Oct 8 10:45:23 CEST 2018


Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/28966 )

Change subject: Documentation: Improve elgon documentation
......................................................................

Documentation: Improve elgon documentation

* Convert PNG to JPG and reduce image quality.
* Mark flash IC and USB serial connector.
* Mark SPI programming header.
* Add programming header pinout.

Change-Id: Ica5958545ed23573a0d48dfa422ad1a822d06b47
Signed-off-by: Patrick Rudolph <patrick.rudolph at 9elements.com>
Reviewed-on: https://review.coreboot.org/28966
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
---
M Documentation/mainboard/opencellular/elgon.md
A Documentation/mainboard/opencellular/elgon1.jpg
D Documentation/mainboard/opencellular/elgon1.png
A Documentation/mainboard/opencellular/elgon2.jpg
D Documentation/mainboard/opencellular/elgon2.png
A Documentation/mainboard/opencellular/elgon_conn_j9.png
A Documentation/mainboard/opencellular/elgon_conn_j9_pcb.jpg
7 files changed, 18 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Philipp Deppenwiese: Looks good to me, approved



diff --git a/Documentation/mainboard/opencellular/elgon.md b/Documentation/mainboard/opencellular/elgon.md
index 37d05e6..02225a2 100644
--- a/Documentation/mainboard/opencellular/elgon.md
+++ b/Documentation/mainboard/opencellular/elgon.md
@@ -40,20 +40,32 @@
 The EVT board does have a pinheader to flash the SOIC-8 in circuit.
 Directly connecting a Pomona test-clip on the flash is also possible.
 
-TODO: pinout
-
 **Total board view of EVT**
 
 ![][elgon1]
 
-[elgon1]: elgon1.png
+[elgon1]: elgon1.jpg
 
-**Closeup view of SOIC-8 flash IC, programming pin header and
-USB serial connector of EVT**
+**Closeup view of SOIC-8 flash IC and USB serial connector of EVT (marked blue)**
 
 ![][elgon2]
 
-[elgon2]: elgon2.png
+[elgon2]: elgon2.jpg
+
+
+**SPI header (marked blue)**
+
+![][elgon_conn_j9_pcb]
+
+[elgon_conn_j9_pcb]: elgon_conn_j9_pcb.jpg
+
+**SPI header pinout**
+
+Dediprog compatible pinout.
+
+![][elgon_conn_j9]
+
+[elgon_conn_j9]: elgon_conn_j9.png
 
 ## Technology
 
diff --git a/Documentation/mainboard/opencellular/elgon1.jpg b/Documentation/mainboard/opencellular/elgon1.jpg
new file mode 100644
index 0000000..4bb72cf
--- /dev/null
+++ b/Documentation/mainboard/opencellular/elgon1.jpg
Binary files differ
diff --git a/Documentation/mainboard/opencellular/elgon1.png b/Documentation/mainboard/opencellular/elgon1.png
deleted file mode 100644
index c1eb544..0000000
--- a/Documentation/mainboard/opencellular/elgon1.png
+++ /dev/null
Binary files differ
diff --git a/Documentation/mainboard/opencellular/elgon2.jpg b/Documentation/mainboard/opencellular/elgon2.jpg
new file mode 100644
index 0000000..63c0b6c
--- /dev/null
+++ b/Documentation/mainboard/opencellular/elgon2.jpg
Binary files differ
diff --git a/Documentation/mainboard/opencellular/elgon2.png b/Documentation/mainboard/opencellular/elgon2.png
deleted file mode 100644
index f12a734..0000000
--- a/Documentation/mainboard/opencellular/elgon2.png
+++ /dev/null
Binary files differ
diff --git a/Documentation/mainboard/opencellular/elgon_conn_j9.png b/Documentation/mainboard/opencellular/elgon_conn_j9.png
new file mode 100644
index 0000000..345d616
--- /dev/null
+++ b/Documentation/mainboard/opencellular/elgon_conn_j9.png
Binary files differ
diff --git a/Documentation/mainboard/opencellular/elgon_conn_j9_pcb.jpg b/Documentation/mainboard/opencellular/elgon_conn_j9_pcb.jpg
new file mode 100644
index 0000000..9e21769
--- /dev/null
+++ b/Documentation/mainboard/opencellular/elgon_conn_j9_pcb.jpg
Binary files differ

-- 
To view, visit https://review.coreboot.org/28966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica5958545ed23573a0d48dfa422ad1a822d06b47
Gerrit-Change-Number: 28966
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks at gmail.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181008/c565619b/attachment.html>


More information about the coreboot-gerrit mailing list