[coreboot-gerrit] Change in coreboot[master]: src/mainboard: Use macro instead of "PCI_DEV(0, 0x1f, 0)"

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28957 )

Change subject: src/mainboard: Use macro instead of "PCI_DEV(0, 0x1f, 0)"
......................................................................


Patch Set 2: Code-Review-1

I don't like number hiding macros. Well, in the case of LPC_DEV, most
people probably know that it's 0x1f. But some don't.

And for this device in particular, LPC ist just the historical name.
It has nothing to do with the functions actually configured.

I remember from the gm45/ich9 port that we used macros like D0F0,
D31F0 etc. That's a good trade-off, IMO, if you want to save some
line length.


-- 
To view, visit https://review.coreboot.org/28957
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e340d42cc9498740fa7158f76472e26b5509695
Gerrit-Change-Number: 28957
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Mon, 08 Oct 2018 07:29:02 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181008/2ec29c11/attachment.html>