[coreboot-gerrit] Change in coreboot[master]: mb/google/fizz: Add variant API for gpio
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Mon Oct 8 07:42:24 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28963 )
Change subject: mb/google/fizz: Add variant API for gpio
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/28963/1/src/mainboard/google/fizz/variants/baseboard/gpio.c
File src/mainboard/google/fizz/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/28963/1/src/mainboard/google/fizz/variants/baseboard/gpio.c@258
PS1, Line 258: const struct pad_config * __attribute__((weak)) variant_gpio_table(size_t *num)
"foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/28963/1/src/mainboard/google/fizz/variants/baseboard/gpio.c@263
PS1, Line 263: const struct pad_config * __attribute__((weak))
"foo * bar" should be "foo *bar"
--
To view, visit https://review.coreboot.org/28963
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaafa8d6932bc0a37826175b15816f1b9a4f4c314
Gerrit-Change-Number: 28963
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu <david_wu at quanta.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 08 Oct 2018 05:42:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181008/2b212edd/attachment.html>
More information about the coreboot-gerrit
mailing list