[coreboot-gerrit] Change in coreboot[master]: src: Standardize PCI_DEV(0, 0x1f, 0) name

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Sun Oct 7 15:52:07 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28956 )

Change subject: src: Standardize PCI_DEV(0, 0x1f, 0) name
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/28956/1/src/soc/intel/fsp_baytrail/include/soc/lpc.h
File src/soc/intel/fsp_baytrail/include/soc/lpc.h:

https://review.coreboot.org/#/c/28956/1/src/soc/intel/fsp_baytrail/include/soc/lpc.h@20
PS1, Line 20: #define FADT_LPC_DEV 0, PCI_DEVFN(0x1f, 0)
Macros with complex values should be enclosed in parentheses


https://review.coreboot.org/#/c/28956/1/src/southbridge/intel/fsp_rangeley/soc.h
File src/southbridge/intel/fsp_rangeley/soc.h:

https://review.coreboot.org/#/c/28956/1/src/southbridge/intel/fsp_rangeley/soc.h@96
PS1, Line 96: #define LPC_DEVFN 0, PCI_DEVFN(0x1f, 0)
Macros with complex values should be enclosed in parentheses



-- 
To view, visit https://review.coreboot.org/28956
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0be00e5e9c733bbeb863250bd51eea8d33f54300
Gerrit-Change-Number: 28956
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 07 Oct 2018 13:52:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181007/4426cf96/attachment.html>


More information about the coreboot-gerrit mailing list