[coreboot-gerrit] Change in coreboot[master]: treewide: use /usr/bin/env where appropriate

[Yegor Timoshenko (Code Review)]

Yegor Timoshenko has posted comments on this change. ( https://review.coreboot.org/28953 )

Change subject: treewide: use /usr/bin/env where appropriate
......................................................................


Patch Set 1:

(3 comments)

Thank you for review! :-)

Will change `/usr/bin/env python` to `/usr/bin/env python2` where appropriate.

https://review.coreboot.org/#/c/28953/1/util/amdtools/k8-compare-pci-space.pl
File util/amdtools/k8-compare-pci-space.pl:

https://review.coreboot.org/#/c/28953/1/util/amdtools/k8-compare-pci-space.pl@5
PS1, Line 5: use warnings;
> Why has this been added?
This has the same effect as `-w` flag. Shebangs can only have one argument, which in this case is program basename. See: https://stackoverflow.com/a/570279


https://review.coreboot.org/#/c/28953/1/util/chromeos/extract_blobs.sh
File util/chromeos/extract_blobs.sh:

https://review.coreboot.org/#/c/28953/1/util/chromeos/extract_blobs.sh@17
PS1, Line 17: set -x
> What is this for?
This flag makes shell print every command invocation to stderr. It was in shebang.


https://review.coreboot.org/#/c/28953/1/util/ipqheader/mbn_tools.py
File util/ipqheader/mbn_tools.py:

https://review.coreboot.org/#/c/28953/1/util/ipqheader/mbn_tools.py@1
PS1, Line 1: #!/usr/bin/env python
> This resolves to Python 3 in my system (Arch Linux), but this script seems Python 2 (I get syntax er […]
This probably would have been the case with previous shebang as well though.

I agree this should be `/usr/bin/env python2`.



-- 
To view, visit https://review.coreboot.org/28953
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7546bcb881c532adc984577ecb0ee2ec4f2efe00
Gerrit-Change-Number: 28953
Gerrit-PatchSet: 1
Gerrit-Owner: Yegor Timoshenko <yegortimoshenko at riseup.net>
Gerrit-Reviewer: Yegor Timoshenko <yegortimoshenko at riseup.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus at gmail.com>
Gerrit-Comment-Date: Sun, 07 Oct 2018 12:39:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181007/e6d0c8b4/attachment.html>