[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/pcr: Add NULL pointer check in pcr_execute_sid...

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Sun Oct 7 06:01:55 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28949 )

Change subject: soc/intel/common/block/pcr: Add NULL pointer check in pcr_execute_sideband_msg()
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/28949/2/src/soc/intel/common/block/pcr/pcr.c
File src/soc/intel/common/block/pcr/pcr.c:

https://review.coreboot.org/#/c/28949/2/src/soc/intel/common/block/pcr/pcr.c@267
PS2, Line 267: 		printk(BIOS_ERR, "Pointer checked for NULL Fail! " \
Avoid unnecessary line continuations



-- 
To view, visit https://review.coreboot.org/28949
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39324514079f240ba1683a04e579de85485299bf
Gerrit-Change-Number: 28949
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Ronald G. Minnich <rminnich at gmail.com>
Gerrit-Comment-Date: Sun, 07 Oct 2018 04:01:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181007/efe9fb4a/attachment.html>


More information about the coreboot-gerrit mailing list