[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Set PCIEXPWAK_DIS if WAKE# pin is not enabled

Furquan Shaikh (Code Review) gerrit at coreboot.org
Fri Oct 5 21:01:56 CEST 2018


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/28939

to look at the new patch set (#3).

Change subject: soc/intel/skylake: Set PCIEXPWAK_DIS if WAKE# pin is not enabled
......................................................................

soc/intel/skylake: Set PCIEXPWAK_DIS if WAKE# pin is not enabled

This change sets PCIEXPWAK_DIS in PM1_EN register if WAKE# pin is not
enabled on the platform. This is required to prevent unnecessary wakes
if the WAKE# pin remains not connected on the platform.

BUG=b:117284700
TEST=Verified that no spurious wakes are observed on nocturne.

Change-Id: Iea93baffc9bb703c0ffedacafc6a9a9410c7ebfe
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/soc/intel/skylake/cpu.c
1 file changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/28939/3
-- 
To view, visit https://review.coreboot.org/28939
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea93baffc9bb703c0ffedacafc6a9a9410c7ebfe
Gerrit-Change-Number: 28939
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181005/1ffd9c4d/attachment.html>


More information about the coreboot-gerrit mailing list