[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add back PM TIMER EMULATION

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/28937 )

Change subject: soc/intel/cannonlake: Add back PM TIMER EMULATION
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/28937/2/src/soc/intel/cannonlake/include/soc/msr.h
File src/soc/intel/cannonlake/include/soc/msr.h:

https://review.coreboot.org/#/c/28937/2/src/soc/intel/cannonlake/include/soc/msr.h@24
PS2, Line 24:  
> is this extra space?
Usually people have an extra space to differentiate a whole register and register bit under, I can take that out to avoid confusion.



-- 
To view, visit https://review.coreboot.org/28937
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie069e815e6244c3f85fabf51e186311621d316fd
Gerrit-Change-Number: 28937
Gerrit-PatchSet: 2
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Subrata Banik <subi.banik at gmail.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 18:59:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181005/e6d94a91/attachment.html>