[coreboot-gerrit] Change in coreboot[master]: Unify all Lenovo t520 variants

[Peter Lemenkov (Code Review)]

Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/28936 )

Change subject: Unify all Lenovo t520 variants
......................................................................


Patch Set 2:

> Build Failed
 > 
 > https://qa.coreboot.org/job/coreboot-gerrit/80240/ : FAILURE
 > 
 > https://qa.coreboot.org/job/coreboot-checkpatch/33914/ : SUCCESS

Not sure if I understand it correctly:

#!!!!! Error: #if CONFIG_BOARD_LENOVO_T520 used at src/mainboard/lenovo/t520/smihandler.c:36.  IS_ENABLED should be used for type 'bool'
#!!!!! Error: #if CONFIG_BOARD_LENOVO_T520 used at src/mainboard/lenovo/t520/smihandler.c:46.  IS_ENABLED should be used for type 'bool'
# 2 errors

Isn't this actually a proper declaration of a bool variable?

config BOARD_LENOVO_L520
        bool "ThinkPad L520"
        select BOARD_LENOVO_BASEBOARD_T520


-- 
To view, visit https://review.coreboot.org/28936
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I936ec6e51dc74637439d8562070443904071708c
Gerrit-Change-Number: 28936
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Lemenkov <lemenkov at gmail.com>
Gerrit-Reviewer: Peter Lemenkov <lemenkov at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 05 Oct 2018 14:16:47 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181005/f788a71d/attachment.html>