[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/nocturne: Disable WAKE# signal

Furquan Shaikh (Code Review) gerrit at coreboot.org
Fri Oct 5 08:30:21 CEST 2018


Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/28926 )

Change subject: mb/google/poppy/variant/nocturne: Disable WAKE# signal
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28926/1/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
File src/mainboard/google/poppy/variants/nocturne/devicetree.cb:

https://review.coreboot.org/#/c/28926/1/src/mainboard/google/poppy/variants/nocturne/devicetree.cb@396
PS1, Line 396: GPE0_PCI_EXP
This should also be updated as it is not correct.



-- 
To view, visit https://review.coreboot.org/28926
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c25e4ba28cd2b8807cd155d47c29c0d3ee9e8a5
Gerrit-Change-Number: 28926
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 05 Oct 2018 06:30:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181005/fa19b94d/attachment.html>


More information about the coreboot-gerrit mailing list