[coreboot-gerrit] Change in coreboot[master]: drivers/spi/winbond: Add new chip
Philipp Deppenwiese (Code Review)
gerrit at coreboot.org
Fri Oct 5 05:25:24 CEST 2018
Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/28861 )
Change subject: drivers/spi/winbond: Add new chip
......................................................................
drivers/spi/winbond: Add new chip
The W25Q128J is a QSPI flash chip, without ~HOLD and ~WP.
Add the device id to make coreboot boot from it.
Change-Id: I623fdf7d7e30eb28259bec6294785ad873f1f503
Signed-off-by: Patrick Rudolph <patrick.rudolph at 9elements.com>
Reviewed-on: https://review.coreboot.org/28861
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Angel Pons <th3fanbus at gmail.com>
Reviewed-by: Julius Werner <jwerner at chromium.org>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
---
M src/drivers/spi/winbond.c
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Philipp Deppenwiese: Looks good to me, approved
Julius Werner: Looks good to me, approved
Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/drivers/spi/winbond.c b/src/drivers/spi/winbond.c
index a6089b5..e2c6538 100644
--- a/src/drivers/spi/winbond.c
+++ b/src/drivers/spi/winbond.c
@@ -179,6 +179,16 @@
.bp_bits = 3,
},
{
+ .id = 0x7018,
+ .l2_page_size_shift = 8,
+ .pages_per_sector_shift = 4,
+ .sectors_per_block_shift = 4,
+ .nr_blocks_shift = 8,
+ .name = "W25Q128J",
+ .protection_granularity_shift = 18,
+ .bp_bits = 3,
+ },
+ {
.id = 0x4019,
.l2_page_size_shift = 8,
.pages_per_sector_shift = 4,
--
To view, visit https://review.coreboot.org/28861
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I623fdf7d7e30eb28259bec6294785ad873f1f503
Gerrit-Change-Number: 28861
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks at gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-CC: Paul Menzel <paulepanter at users.sourceforge.net>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181005/5d9a761c/attachment.html>
More information about the coreboot-gerrit
mailing list