[coreboot-gerrit] Change in coreboot[master]: soc/intel/common, mb/google, mb/siemens: Use lower case x for RXD

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28924 )

Change subject: soc/intel/common, mb/google, mb/siemens: Use lower case x for RXD
......................................................................


Patch Set 1:

(9 comments)

https://review.coreboot.org/#/c/28924/1/src/mainboard/google/octopus/variants/baseboard/gpio.c
File src/mainboard/google/octopus/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/28924/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@149
PS1, Line 149: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_105, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD),/* GPIO_105 -- TOUCHSCREEN_RST */
line over 80 characters


https://review.coreboot.org/#/c/28924/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@205
PS1, Line 205: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD),/* GPIO_140 -- PEN_RESET */
line over 80 characters


https://review.coreboot.org/#/c/28924/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@226
PS1, Line 226: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_161, 1, DEEP, UP_20K, Tx1RxDCRx0, DISPUPD), /* AVS_I2S1_MCLK -- LTE_OFF_ODL */
line over 80 characters


https://review.coreboot.org/#/c/28924/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@247
PS1, Line 247: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD), /* EN_PP3300_WLAN */
line over 80 characters


https://review.coreboot.org/#/c/28924/1/src/mainboard/google/octopus/variants/bip/gpio.c
File src/mainboard/google/octopus/variants/bip/gpio.c:

https://review.coreboot.org/#/c/28924/1/src/mainboard/google/octopus/variants/bip/gpio.c@147
PS1, Line 147: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_105, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD),/* GPIO_105 -- TOUCHSCREEN_RST */
line over 80 characters


https://review.coreboot.org/#/c/28924/1/src/mainboard/google/octopus/variants/bip/gpio.c@204
PS1, Line 204: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 0, DEEP, NONE, Tx1RxDCRx0, DISPUPD),/* GPIO_140 -- PEN_RESET */
line over 80 characters


https://review.coreboot.org/#/c/28924/1/src/mainboard/google/octopus/variants/bip/gpio.c@246
PS1, Line 246: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD), /* EN_PP3300_WLAN */
line over 80 characters


https://review.coreboot.org/#/c/28924/1/src/mainboard/google/reef/variants/baseboard/gpio.c
File src/mainboard/google/reef/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/28924/1/src/mainboard/google/reef/variants/baseboard/gpio.c@330
PS1, Line 330: 	PAD_CFG_NF_IOSSTATE(GPIO_47, NATIVE, DEEP, NF1, Tx1RxDCRx0), /* LPSS_UART2_TXD */
line over 80 characters


https://review.coreboot.org/#/c/28924/1/src/mainboard/google/reef/variants/coral/gpio.c
File src/mainboard/google/reef/variants/coral/gpio.c:

https://review.coreboot.org/#/c/28924/1/src/mainboard/google/reef/variants/coral/gpio.c@330
PS1, Line 330: 	PAD_CFG_NF_IOSSTATE(GPIO_47, NATIVE, DEEP, NF1, Tx1RxDCRx0), /* LPSS_UART2_TXD */
line over 80 characters



-- 
To view, visit https://review.coreboot.org/28924
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b1ce259ed184bcf8224dff334fcf0a0289f1788
Gerrit-Change-Number: 28924
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 04 Oct 2018 18:18:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181004/4a95a8e4/attachment.html>