[coreboot-gerrit] Change in coreboot[master]: nb/intel/{gm45, i945, pineview}: Use macro instead of GGC address

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28909 )

Change subject: nb/intel/{gm45,i945,pineview}: Use macro instead of GGC address
......................................................................


Patch Set 2:

>> (1 comment)
> 
> regarding the datasheet, it is 16bits.

The register read was already 16 bits. That has nothing to do with
the variable you store the value in.

> 
> by the way, there is a conflict with this change :
> https://review.coreboot.org/#/c/coreboot/+/17645/
> so maybe I have to keep only changes related to pineview and i945.

Doesn't matter. 17645 needs an update anyway.


-- 
To view, visit https://review.coreboot.org/28909
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I233e835180fd445961b6deb74ea7afc2821c236e
Gerrit-Change-Number: 28909
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 04 Oct 2018 15:28:11 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181004/c1f89c75/attachment.html>