[coreboot-gerrit] Change in coreboot[master]: libpayload/x86/exception.c: Remove exception_install_hook

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28881 )

Change subject: libpayload/x86/exception.c: Remove exception_install_hook
......................................................................

libpayload/x86/exception.c: Remove exception_install_hook

Not used by x86 code anymore.

BUG=b:116777191
TEST=Validated that depthcharge can be built.

Change-Id: I25ad3903989a5433ce73d657cfdb93dd1f34f7b5
Signed-off-by: Raul E Rangel <rrangel at chromium.org>
Reviewed-on: https://review.coreboot.org/28881
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Martin Roth <martinroth at google.com>
---
M payloads/libpayload/arch/x86/exception.c
1 file changed, 0 insertions(+), 11 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved



diff --git a/payloads/libpayload/arch/x86/exception.c b/payloads/libpayload/arch/x86/exception.c
index 3cd95bb..1fa1304 100644
--- a/payloads/libpayload/arch/x86/exception.c
+++ b/payloads/libpayload/arch/x86/exception.c
@@ -37,8 +37,6 @@
 
 u32 exception_stack[0x400] __attribute__((aligned(8)));
 
-static exception_hook hook;
-
 static interrupt_handler handlers[256];
 
 static const char *names[EXC_COUNT] = {
@@ -181,9 +179,6 @@
 	die_if(vec >= EXC_COUNT || !names[vec], "Bad exception vector %u\n",
 	       vec);
 
-	if (hook && hook(vec))
-		return;
-
 	dump_exception_state();
 	dump_stack(exception_state->regs.esp, 512);
 	halt();
@@ -195,12 +190,6 @@
 	exception_init_asm();
 }
 
-void exception_install_hook(exception_hook h)
-{
-	die_if(hook, "Implement support for a list of hooks if you need it.");
-	hook = h;
-}
-
 void set_interrupt_handler(u8 vector, interrupt_handler handler)
 {
 	handlers[vector] = handler;

-- 
To view, visit https://review.coreboot.org/28881
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I25ad3903989a5433ce73d657cfdb93dd1f34f7b5
Gerrit-Change-Number: 28881
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181004/76d2d85f/attachment.html>