[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Allow mainboard to update I2C at runtime

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Wed Oct 3 21:04:00 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28904 )

Change subject: soc/amd/stoneyridge: Allow mainboard to update I2C at runtime
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/28904/2/src/soc/amd/stoneyridge/i2c.c
File src/soc/amd/stoneyridge/i2c.c:

https://review.coreboot.org/#/c/28904/2/src/soc/amd/stoneyridge/i2c.c@59
PS2, Line 59: void __weak mb_update_i2c(unsigned int bus, const struct dw_i2c_bus_config **i2c_vals) {}
line over 80 characters



-- 
To view, visit https://review.coreboot.org/28904
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id00c352a04b3d7845027882bcfcee09518787067
Gerrit-Change-Number: 28904
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu at quantatw.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin at chromium.org>
Gerrit-Comment-Date: Wed, 03 Oct 2018 19:04:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181003/b8fd053b/attachment.html>


More information about the coreboot-gerrit mailing list