[coreboot-gerrit] Change in coreboot[master]: src/nb/i945: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28878 )

Change subject: src/nb/i945: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement
......................................................................


Patch Set 3:

>> Using #if is a bad habit. Also, what are the outer parentheses for?
> 
> If I'm not wrong, '#if' is used in (romstage) to bypass the code if
> the statement is not true.

You can use it like that. But that's not specific to any stage. And
it's a bad choice because the guarded code won't be compile tested.

There is no other way to do this in romcc bootblock code, maybe
that is what you had in mind?


-- 
To view, visit https://review.coreboot.org/28878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ff87c76b3aef4af93d88dd9c02a743656aacfc0
Gerrit-Change-Number: 28878
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 03 Oct 2018 11:41:56 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181003/0ab8ebd4/attachment.html>