[coreboot-gerrit] Change in coreboot[master]: src/mb: Remove dead code

Nico Huber (Code Review) gerrit at coreboot.org
Wed Oct 3 13:34:27 CEST 2018


Nico Huber has posted comments on this change. ( https://review.coreboot.org/28876 )

Change subject: src/mb: Remove dead code
......................................................................


Patch Set 4:

Ah, looks like my doubts were misplaced. It should have compiled. The
errors in PS#3 were introduced by the patch...

I wouldn't object if we drop the code but if, we should also drop the
then obsolete implementation. I would ack it, if you think it's the
right thing. But I can't ack it if you are just following my examples
what could be done.


-- 
To view, visit https://review.coreboot.org/28876
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I318de3e7c807bb5b5efdf61fef387d34225a8149
Gerrit-Change-Number: 28876
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 03 Oct 2018 11:34:27 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181003/ea11be1e/attachment.html>


More information about the coreboot-gerrit mailing list