[coreboot-gerrit] Change in coreboot[master]: google/grunt: extract OEM string from CBFS

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Wed Oct 3 04:16:29 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28889 )

Change subject: google/grunt: extract OEM string from CBFS
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28889/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c
File src/mainboard/google/kahlee/variants/baseboard/mainboard.c:

https://review.coreboot.org/#/c/28889/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@94
PS1, Line 94: 	if(oem_bin_data[0] != '\0')
space required before the open parenthesis '('



-- 
To view, visit https://review.coreboot.org/28889
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f1bbb690ecca515ac920f5058ee19b5bfd8fa5e
Gerrit-Change-Number: 28889
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <Kevin.Chiu at quantatw.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 03 Oct 2018 02:16:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181003/654033ff/attachment.html>


More information about the coreboot-gerrit mailing list