[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Add IOMMU support

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/28753 )

Change subject: soc/amd/stoneyridge: Add IOMMU support
......................................................................


Patch Set 1:

(2 comments)

> Patch Set 1:
> 
> (2 comments)

https://review.coreboot.org/#/c/28753/1/src/soc/amd/stoneyridge/iommu.c
File src/soc/amd/stoneyridge/iommu.c:

https://review.coreboot.org/#/c/28753/1/src/soc/amd/stoneyridge/iommu.c@30
PS1, Line 30: 0x44
> Any reason this value was chosen?
no, it is an arbitrary id for the resource. It is used by other iommu.c resource, so we should be consitent. *shrug*


https://review.coreboot.org/#/c/28753/1/src/soc/amd/stoneyridge/iommu.c@38
PS1, Line 38: static void iommu_set_resources(struct device *dev)
            : {
            : 	pci_dev_set_resources(dev);
            : }
> Get rid of this and call pci_dev_set_resources directly from the ops table?
Done



-- 
To view, visit https://review.coreboot.org/28753
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I688d867c7bd4949a57b27c1b6a793c6a6e4a717a
Gerrit-Change-Number: 28753
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 02 Oct 2018 20:54:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181002/28c675f7/attachment.html>