[coreboot-gerrit] Change in coreboot[master]: src/lib/edid.c: Replace #if 1 with something useful

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28872


Change subject: src/lib/edid.c: Replace #if 1 with something useful
......................................................................

src/lib/edid.c: Replace #if 1 with something useful

Since `#if 1` is rather useless, and the code inside it is just several
`printk(BIOS_SPEW)`, using `CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8` instead
seems more reasonable.

Change-Id: I93dcab3db958480626fea6d99ab5289ebff04e8f
Signed-off-by: Angel Pons <th3fanbus at gmail.com>
---
M src/lib/edid.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/28872/1

diff --git a/src/lib/edid.c b/src/lib/edid.c
index 9cf9b8a..28773a4 100644
--- a/src/lib/edid.c
+++ b/src/lib/edid.c
@@ -204,7 +204,7 @@
 {
 	struct edid *out = &tmp_edid;
 	int i;
-#if 1
+#if CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8
 	printk(BIOS_SPEW, "Hex of detail: ");
 	for (i = 0; i < 18; i++)
 		printk(BIOS_SPEW, "%02x", x[i]);

-- 
To view, visit https://review.coreboot.org/28872
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93dcab3db958480626fea6d99ab5289ebff04e8f
Gerrit-Change-Number: 28872
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181002/a6bf8e23/attachment.html>