[coreboot-gerrit] Change in coreboot[master]: google/grunt: Update Audio/TP i2c timing

Kevin Chiu (Code Review) gerrit at coreboot.org
Tue Oct 2 03:47:38 CEST 2018


Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/28868


Change subject: google/grunt: Update Audio/TP i2c timing
......................................................................

google/grunt: Update Audio/TP i2c timing

After adjustment on Careena DVT
Audio: 402.805 KHz -> 396.8 KHz
TP: 406.1 KHz -> 399.5 KHz

BUG=b:110984023
BRANCH=master
TEST=emerge-grunt coreboot
Change-Id: Ia3eb91ca3772d5f122498e3989ec03838fce06a5
Signed-off-by: Kevin Chiu <Kevin.Chiu at quantatw.com>
---
M src/mainboard/google/kahlee/variants/careena/devicetree.cb
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/28868/1

diff --git a/src/mainboard/google/kahlee/variants/careena/devicetree.cb b/src/mainboard/google/kahlee/variants/careena/devicetree.cb
index d633134..9769c42 100644
--- a/src/mainboard/google/kahlee/variants/careena/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/careena/devicetree.cb
@@ -27,7 +27,7 @@
 	# Enable I2C0 for audio, USB3 hub at 400kHz
 	register "i2c[0]" = "{
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 95,
+		.rise_time_ns = 58,
 		.fall_time_ns = 3,
 	}"
 
@@ -42,8 +42,8 @@
 	# Enable I2C2 for trackpad, pen at 400kHz
 	register "i2c[2]" = "{
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 67,
-		.fall_time_ns = 55,
+		.rise_time_ns = 25,
+		.fall_time_ns = 11,
 	}"
 
 	# Enable I2C3 for touchscreen at 400kHz

-- 
To view, visit https://review.coreboot.org/28868
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3eb91ca3772d5f122498e3989ec03838fce06a5
Gerrit-Change-Number: 28868
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <Kevin.Chiu at quantatw.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181002/ec14b628/attachment.html>


More information about the coreboot-gerrit mailing list