[coreboot-gerrit] Change in coreboot[master]: drivers/spi/winbond: Add function to lock flash's status register

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Oct 1 16:23:27 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28697 )

Change subject: drivers/spi/winbond: Add function to lock flash's status register
......................................................................


Patch Set 7:

(2 comments)

https://review.coreboot.org/#/c/28697/7/src/drivers/spi/winbond.c
File src/drivers/spi/winbond.c:

https://review.coreboot.org/#/c/28697/7/src/drivers/spi/winbond.c@565
PS7, Line 565: 		        const enum spi_flash_status_reg_lockdown mode,
code indent should use tabs where possible


https://review.coreboot.org/#/c/28697/7/src/drivers/spi/winbond.c@566
PS7, Line 566: 		        const bool non_volatile)
code indent should use tabs where possible



-- 
To view, visit https://review.coreboot.org/28697
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90e0fcdcf531b53c0fc1ffcfdb3b5ab522f088f5
Gerrit-Change-Number: 28697
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks at gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 01 Oct 2018 14:23:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181001/b390e121/attachment.html>


More information about the coreboot-gerrit mailing list