[coreboot-gerrit] Change in coreboot[master]: commonlib/region: Add region protect API

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28724 )

Change subject: commonlib/region: Add region protect API
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/28724/2/src/commonlib/include/commonlib/region.h
File src/commonlib/include/commonlib/region.h:

https://review.coreboot.org/#/c/28724/2/src/commonlib/include/commonlib/region.h@67
PS2, Line 67:  * Returns < 0 on error otherwise returns 0 on success, < 0 0n error.
copy paste error ?


https://review.coreboot.org/#/c/28724/2/src/commonlib/region.c
File src/commonlib/region.c:

https://review.coreboot.org/#/c/28724/2/src/commonlib/region.c@154
PS2, Line 154: int rdev_protect(const struct region_device *rd)
please mention in a comment that it'll make the flash write protected



-- 
To view, visit https://review.coreboot.org/28724
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9376e2c2c7a4852f13c65824c6cd64a1c6ac0a
Gerrit-Change-Number: 28724
Gerrit-PatchSet: 2
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Comment-Date: Mon, 01 Oct 2018 09:55:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181001/a53045e0/attachment.html>