[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Move the FSP related callbacks to separate files

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28661 )

Change subject: soc/intel/cannonlake: Move the FSP related callbacks to separate files
......................................................................


Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/28661/4/src/soc/intel/cannonlake/fsp_params.c
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/#/c/28661/4/src/soc/intel/cannonlake/fsp_params.c@82
PS4, Line 82: 	for (i = 0; i < ARRAY_SIZE(params->Usb2OverCurrentPin); i++) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/28661/4/src/soc/intel/cannonlake/fsp_params.c@86
PS4, Line 86: 	for (i = 0; i < ARRAY_SIZE(params->Usb3OverCurrentPin); i++) {
braces {} are not necessary for single statement blocks



-- 
To view, visit https://review.coreboot.org/28661
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffadc57f6986e688aa1bbe4e5444d105386ad92e
Gerrit-Change-Number: 28661
Gerrit-PatchSet: 4
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Mon, 01 Oct 2018 08:10:04 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181001/f2247df0/attachment.html>