[coreboot-gerrit] Change in ...coreboot[master]: mb/google/sarien: Program HD Audio SVID/SSID

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29651 )

Change subject: mb/google/sarien: Program HD Audio SVID/SSID
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> Could we do this at the SOC level?
> 
> If we had a Kconfig entry in the SOC that allowed the mainboard to define an HDA codec device ID then the SOC level code could have this structure (filled with CONFIG_SUBSYSTEM_VENDOR_ID and something like CONFIG_HDA_CODEC_ID) and pass it to FSP if HDA is enabled.

Sure, thought about that before that sounds better.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29651
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488
Gerrit-Change-Number: 29651
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Jairaj Arava <jairaj.arava at intel.com>
Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Comment-Date: Fri, 30 Nov 2018 19:29:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181130/7427f215/attachment.html>