[coreboot-gerrit] Change in ...coreboot[master]: arch/x86/Kconfig: move MAX_REBOOT_CNT option
Marcello Sylvester Bauer (Code Review)
gerrit at coreboot.org
Fri Nov 30 16:27:28 CET 2018
Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29979 )
Change subject: arch/x86/Kconfig: move MAX_REBOOT_CNT option
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/29979/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29979/1//COMMIT_MSG@11
PS1, Line 11:
> Use case? […]
It only adds the entry, so you don't have to change it in the config file by hand.
In my case I would rather fallback after 2 failed reboots, but also values up to 15 are possible.
https://review.coreboot.org/#/c/29979/1/src/arch/x86/Kconfig
File src/arch/x86/Kconfig:
https://review.coreboot.org/#/c/29979/1/src/arch/x86/Kconfig@274
PS1, Line 274: 0
> 0 would mean every boot has failed? Never use the normal path?
true. it will be changed to 1.
--
To view, visit https://review.coreboot.org/c/coreboot/+/29979
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice26e2ef349f1172b564edc14f1012c33546a93c
Gerrit-Change-Number: 29979
Gerrit-PatchSet: 1
Gerrit-Owner: Marcello Sylvester Bauer <sylvblck at sylv.io>
Gerrit-Reviewer: Marcello Sylvester Bauer <sylvblck at sylv.io>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Fri, 30 Nov 2018 15:27:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181130/b134f69e/attachment.html>
More information about the coreboot-gerrit
mailing list