[coreboot-gerrit] Change in ...coreboot[master]: Coreboot: Add support for USB host mode for mistral platform

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29966 )

Change subject: Coreboot: Add support for USB host mode for mistral platform
......................................................................


Patch Set 2:

(4 comments)

https://review.coreboot.org/#/c/29966/2/src/soc/qualcomm/qcs405/usb.c 
File src/soc/qualcomm/qcs405/usb.c:

https://review.coreboot.org/#/c/29966/2/src/soc/qualcomm/qcs405/usb.c@137 
PS2, Line 137: 	write8(&dwc3->usb2_phy_dig->override_x0, dwc3->board_data->parameter_override_x0);
line over 80 characters


https://review.coreboot.org/#/c/29966/2/src/soc/qualcomm/qcs405/usb.c@138 
PS2, Line 138: 	write8(&dwc3->usb2_phy_dig->override_x1, dwc3->board_data->parameter_override_x1);
line over 80 characters


https://review.coreboot.org/#/c/29966/2/src/soc/qualcomm/qcs405/usb.c@139 
PS2, Line 139: 	write8(&dwc3->usb2_phy_dig->override_x2, dwc3->board_data->parameter_override_x2);
line over 80 characters


https://review.coreboot.org/#/c/29966/2/src/soc/qualcomm/qcs405/usb.c@140 
PS2, Line 140: 	write8(&dwc3->usb2_phy_dig->override_x3, dwc3->board_data->parameter_override_x3);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35ec549b49b9789389c80843f6103e7243d52aac
Gerrit-Change-Number: 29966
Gerrit-PatchSet: 2
Gerrit-Owner: nsekar at codeaurora.org
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: nsekar at codeaurora.org
Gerrit-Comment-Date: Fri, 30 Nov 2018 14:08:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181130/de14cd71/attachment.html>