[coreboot-gerrit] Change in ...coreboot[master]: qcs405:Add SPI_RAM_SIMULATION support for QCS405

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29959 )

Change subject: qcs405:Add SPI_RAM_SIMULATION support for QCS405
......................................................................


Patch Set 2:

(6 comments)

https://review.coreboot.org/#/c/29959/2/src/soc/qualcomm/qcs405/flash_controller.c 
File src/soc/qualcomm/qcs405/flash_controller.c:

https://review.coreboot.org/#/c/29959/2/src/soc/qualcomm/qcs405/flash_controller.c@37 
PS2, Line 37: static int ram_read(const struct spi_flash *flash, u32 addr, size_t len, void *buf)
line over 80 characters


https://review.coreboot.org/#/c/29959/2/src/soc/qualcomm/qcs405/flash_controller.c@68 
PS2, Line 68: {
that open brace { should be on the previous line


https://review.coreboot.org/#/c/29959/2/src/soc/qualcomm/qcs405/flash_controller.c@78 
PS2, Line 78: 	static char name[] = "ram_flash";
static char array declaration should probably be static const char


https://review.coreboot.org/#/c/29959/2/src/soc/qualcomm/qcs405/flash_controller.c@80 
PS2, Line 80: 	printk(BIOS_INFO, "[%s]..CONFIG_QC_SOC_SIMULATE\n", __FUNCTION__);
__func__ should be used instead of gcc specific __FUNCTION__


https://review.coreboot.org/#/c/29959/2/src/soc/qualcomm/qcs405/flash_controller.c@82 
PS2, Line 82: 	printk(BIOS_INFO, "[%s]..ram_flash\n", __FUNCTION__);
__func__ should be used instead of gcc specific __FUNCTION__


https://review.coreboot.org/#/c/29959/2/src/soc/qualcomm/qcs405/mmu.c 
File src/soc/qualcomm/qcs405/mmu.c:

https://review.coreboot.org/#/c/29959/2/src/soc/qualcomm/qcs405/mmu.c@40 
PS2, Line 40: 	mmu_config_range((void *)0x80000000, 0x40000000, MA_MEM | MA_NS | MA_RW);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29959
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I895315a995cbbd5e6a7a305e48476f0d0f583cfe
Gerrit-Change-Number: 29959
Gerrit-PatchSet: 2
Gerrit-Owner: nsekar at codeaurora.org
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: nsekar at codeaurora.org
Gerrit-Comment-Date: Fri, 30 Nov 2018 14:07:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181130/0334f106/attachment.html>