[coreboot-gerrit] Change in ...coreboot[master]: qcs405 [temp]: Combine BB with QC-Sec for ROM boot
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Fri Nov 30 11:17:53 CET 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29973 )
Change subject: qcs405 [temp]: Combine BB with QC-Sec for ROM boot
......................................................................
Patch Set 1:
(39 comments)
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py
File util/qualcomm/createxbl.py:
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@25
PS1, Line 25: # 09/04/15 et Added -x and -d to embed xbl_sec ELF
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@68
PS1, Line 68:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@84
PS1, Line 84:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@103
PS1, Line 103:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@113
PS1, Line 113:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@121
PS1, Line 121:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@144
PS1, Line 144:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@164
PS1, Line 164:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@172
PS1, Line 172:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@192
PS1, Line 192: header_format = 'reg'
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@223
PS1, Line 223:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@231
PS1, Line 231:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@232
PS1, Line 232: # Create hash table
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@235
PS1, Line 235: target_hash,
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@237
PS1, Line 237: secure_type = image_header_secflag)
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@245
PS1, Line 245: target_hash_hd,
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@254
PS1, Line 254: # Add the hash segment into the ELF
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@272
PS1, Line 272: def merge_elfs(env,
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@284
PS1, Line 284: mbn_tools.preprocess_elf_file(elf_in_file_name1)
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@289
PS1, Line 289: mbn_tools.preprocess_elf_file(elf_in_file_name2)
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@290
PS1, Line 290:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@294
PS1, Line 294: mbn_tools.preprocess_elf_file(elf_in_file_xbl_sec)
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@325
PS1, Line 325:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@364
PS1, Line 364:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@400
PS1, Line 400:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@477
PS1, Line 477:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@512
PS1, Line 512:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@614
PS1, Line 614:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@618
PS1, Line 618:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@621
PS1, Line 621:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@640
PS1, Line 640:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@674
PS1, Line 674:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@675
PS1, Line 675:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@681
PS1, Line 681: inp_data_offset = 0
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@682
PS1, Line 682:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@689
PS1, Line 689:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@706
PS1, Line 706:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/createxbl.py@708
PS1, Line 708:
trailing whitespace
https://review.coreboot.org/#/c/29973/1/util/qualcomm/mbn_tools.py
File util/qualcomm/mbn_tools.py:
https://review.coreboot.org/#/c/29973/1/util/qualcomm/mbn_tools.py@1167
PS1, Line 1167: # Check if a shifting is required to accomodate for the hash segment.
'accomodate' may be misspelled - perhaps 'accommodate'?
--
To view, visit https://review.coreboot.org/c/coreboot/+/29973
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief4d92214cdc7ec06e90b0c7e73c11b6d6deddb9
Gerrit-Change-Number: 29973
Gerrit-PatchSet: 1
Gerrit-Owner: nsekar at codeaurora.org
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: nsekar at codeaurora.org
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 30 Nov 2018 10:17:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181130/fb8ff801/attachment.html>
More information about the coreboot-gerrit
mailing list