[coreboot-gerrit] Change in ...coreboot[master]: qclib: Add qclib support

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29967 )

Change subject: qclib: Add qclib support
......................................................................


Patch Set 1:

(14 comments)

https://review.coreboot.org/#/c/29967/1/src/soc/qualcomm/qcs405/qclib_execute.c 
File src/soc/qualcomm/qcs405/qclib_execute.c:

https://review.coreboot.org/#/c/29967/1/src/soc/qualcomm/qcs405/qclib_execute.c@35 
PS1, Line 35: 	int (*doit)(void *, void *);
function definition argument 'void *' should also have an identifier name


https://review.coreboot.org/#/c/29967/1/src/soc/qualcomm/qcs405/qclib_execute.c@35 
PS1, Line 35: 	int (*doit)(void *, void *);
function definition argument 'void *' should also have an identifier name


https://review.coreboot.org/#/c/29967/1/src/soc/qualcomm/qcs405/qclib_execute.c@43 
PS1, Line 43:         struct prog pmic =
code indent should use tabs where possible


https://review.coreboot.org/#/c/29967/1/src/soc/qualcomm/qcs405/qclib_execute.c@43 
PS1, Line 43:         struct prog pmic =
please, no spaces at the start of a line


https://review.coreboot.org/#/c/29967/1/src/soc/qualcomm/qcs405/qclib_execute.c@44 
PS1, Line 44:                 PROG_INIT(PROG_REFCODE, CONFIG_CBFS_PREFIX PMIC_NAME);
code indent should use tabs where possible


https://review.coreboot.org/#/c/29967/1/src/soc/qualcomm/qcs405/qclib_execute.c@44 
PS1, Line 44:                 PROG_INIT(PROG_REFCODE, CONFIG_CBFS_PREFIX PMIC_NAME);
please, no spaces at the start of a line


https://review.coreboot.org/#/c/29967/1/src/soc/qualcomm/qcs405/qclib_execute.c@52 
PS1, Line 52:         if (prog_locate(&pmic))
code indent should use tabs where possible


https://review.coreboot.org/#/c/29967/1/src/soc/qualcomm/qcs405/qclib_execute.c@52 
PS1, Line 52:         if (prog_locate(&pmic))
please, no spaces at the start of a line


https://review.coreboot.org/#/c/29967/1/src/soc/qualcomm/qcs405/qclib_execute.c@53 
PS1, Line 53:                 goto fail;
code indent should use tabs where possible


https://review.coreboot.org/#/c/29967/1/src/soc/qualcomm/qcs405/qclib_execute.c@53 
PS1, Line 53:                 goto fail;
please, no spaces at the start of a line


https://review.coreboot.org/#/c/29967/1/src/soc/qualcomm/qcs405/qclib_execute.c@55 
PS1, Line 55:         if (cbfs_prog_stage_load(&pmic))
code indent should use tabs where possible


https://review.coreboot.org/#/c/29967/1/src/soc/qualcomm/qcs405/qclib_execute.c@55 
PS1, Line 55:         if (cbfs_prog_stage_load(&pmic))
please, no spaces at the start of a line


https://review.coreboot.org/#/c/29967/1/src/soc/qualcomm/qcs405/qclib_execute.c@56 
PS1, Line 56:                 goto fail;
code indent should use tabs where possible


https://review.coreboot.org/#/c/29967/1/src/soc/qualcomm/qcs405/qclib_execute.c@56 
PS1, Line 56:                 goto fail;
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29967
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I534af71163d034ea04420dda6a94ce31b08c8a07
Gerrit-Change-Number: 29967
Gerrit-PatchSet: 1
Gerrit-Owner: nsekar at codeaurora.org
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: nsekar at codeaurora.org
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 30 Nov 2018 10:17:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181130/e05cc974/attachment.html>