[coreboot-gerrit] Change in ...coreboot[master]: riscv: add support to select the privilege level of the payload running
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Fri Nov 30 08:05:08 CET 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29494 )
Change subject: riscv: add support to select the privilege level of the payload running
......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/#/c/29494/9/src/arch/riscv/boot.c
File src/arch/riscv/boot.c:
https://review.coreboot.org/#/c/29494/9/src/arch/riscv/boot.c@43
PS9, Line 43: void (*fn)(uintptr_t, uintptr_t) = prog_entry(prog);
function definition argument 'uintptr_t' should also have an identifier name
https://review.coreboot.org/#/c/29494/9/src/arch/riscv/boot.c@43
PS9, Line 43: void (*fn)(uintptr_t, uintptr_t) = prog_entry(prog);
function definition argument 'uintptr_t' should also have an identifier name
https://review.coreboot.org/#/c/29494/9/src/arch/riscv/boot.c@49
PS9, Line 49: void (*doit)(void *) = prog_entry(prog);
function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/29494/9/src/arch/riscv/payload.c
File src/arch/riscv/payload.c:
https://review.coreboot.org/#/c/29494/9/src/arch/riscv/payload.c@28
PS9, Line 28: uintptr_t status = read_csr(mstatus)
trailing whitespace
--
To view, visit https://review.coreboot.org/c/coreboot/+/29494
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96961246cd257b63cf167238aa0cf6e65272b951
Gerrit-Change-Number: 29494
Gerrit-PatchSet: 9
Gerrit-Owner: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Hug <philipp at hug.cx>
Gerrit-Reviewer: Shawn Chang <citypw at gmail.com>
Gerrit-Reviewer: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich at gmail.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 07:05:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181130/e82c9373/attachment.html>
More information about the coreboot-gerrit
mailing list